[in progress] Expose API for parameter server #1039
Conversation
jacquesqiao
changed the title
| void init(); | ||
| void start(); | ||
| void join(); | ||
|
|
There was a problem hiding this comment.
DISABLE_COPY(PServerUtil);
|
|
||
| class PServerUtil { | ||
| public: | ||
| void init(); |
There was a problem hiding this comment.
这里如果方便的话，可以考虑把GFLAGS提取出来，变成函数的参数。
| void init(); | ||
| void start(); | ||
| void join(); | ||
|
|
| void join(); | ||
|
|
||
| private: | ||
| std::vector<std::shared_ptr<ParameterServer2>> pservers_; |
There was a problem hiding this comment.
看起来，std::vector<std::unique_ptr< ParameterServer2 >> pservers_;
就够了
| for (auto& pserver : pservers) { | ||
| pserver->join(); | ||
| } | ||
| PServerUtil* pserverUtil = new PServerUtil(); |
There was a problem hiding this comment.
std::unique_ptr pservers(new PServerUtil());
把init实现在构造函数里，把join放到析构函数里的。
pservers->start();
| } | ||
| } | ||
| } | ||
| PServerUtil* pserverUtil = new PServerUtil(); |
There was a problem hiding this comment.
同上。这里new完了都没有delete。
如果不是必要，不要用C++的裸指针。
如果这个对象不会被多个对象使用，用unique_ptr
如果这个对象会被多个对象使用，用shared_ptr
| @@ -0,0 +1,77 @@ | |||
| /* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve. | |||
There was a problem hiding this comment.
Please refer to source file naming convention and rename this to be pserver_util.cpp.
| @@ -0,0 +1,33 @@ | |||
| /* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve. | |||
There was a problem hiding this comment.
Please refer to source file naming convention and rename this to be pserver_util.h.
There was a problem hiding this comment.
好的，代码规范问题，会在分开的两个pr中进行，这个pr先关掉。
|
|
||
| from py_paddle import swig_paddle as api | ||
|
|
||
| #import pudb;pudb.set_trace() |
There was a problem hiding this comment.
Please remove the unused line other than commenting it out.
| @@ -0,0 +1,33 @@ | |||
| /* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve. | |||
There was a problem hiding this comment.
Please refer to source file naming convention and rename this to be parameter_server.cpp.
| def main(): | ||
| api.initPaddle("--nics=lo0", "--port=7164", "--ports_num=1", | ||
| "--num_gradient_servers=1", "--comment=paddle_pserver") | ||
| pserver = api.ParameterServer.createParameterServer() |
There was a problem hiding this comment.
我没有太看明白这里的API设计。我以为这里是想通过调用Python API启动一个parameter server process？
如果是，那么是不是应该把 L21到L26简化为，比如：
psid = api.pserver.start(nics="lo0", port=7164, ports_num=1, num_gradient_server=1, comment="paddle_pserver")
api.pserver.wait(psid)
There was a problem hiding this comment.
对，这个后面正在修改，目前长这个样子是因为历史遗留问题，initPaddle实际上是去初始化各种gflags，后面的版本已经改成proto配置了，见#1051
| def main(): | ||
| api.initPaddle("--nics=lo0", "--port=7164", "--ports_num=1", | ||
| "--num_gradient_servers=1", "--comment=paddle_pserver") | ||
| pserver = api.ParameterServer.createParameterServer() |
There was a problem hiding this comment.
Please follow Python code convention and rename module/package name ParameterServer to be pserver or parameter_server.
as comment of @reyoung, split this pr into two. one for pserver and one for swig.
1, PserverUtil #1051
2, swig api. TBD