Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #10480

Merged
merged 5 commits into from
May 8, 2018
Merged

Fix CI #10480

merged 5 commits into from
May 8, 2018

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented May 8, 2018 •
edited

fix #10481

@chengduoZH chengduoZH changed the title Fix MatMul of cove Fix MatMul of conv_op May 8, 2018
@chengduoZH chengduoZH requested a review from reyoung May 8, 2018 04:52
@chengduoZH chengduoZH mentioned this pull request May 8, 2018
Closed
@chengduoZH chengduoZH mentioned this pull request May 8, 2018
Closed
@reyoung
Copy link
Collaborator

reyoung commented May 8, 2018

There is no unit test for this operator?

@chengduoZH
Copy link
Contributor Author

The previous teamcity CI setting has some issues, causing some test failures cannot be caught······

@chengduoZH chengduoZH changed the title Fix MatMul of conv_op Fix CI May 8, 2018
@chengduoZH chengduoZH requested a review from luotao1 May 8, 2018 11:31
luotao1
luotao1 approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit 22ab14c into PaddlePaddle:develop May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failed, because of conv_op
3 participants
@chengduoZH @reyoung @luotao1