add dist transpiler unit test #10485
Conversation
| @@ -0,0 +1,74 @@ | |||
| # Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
The name is common.py while it's not quite "common", see #9770 (comment) for details
There was a problem hiding this comment.
Thanks! common.py is only used by distribute_transpiler, so I delete it and reuse it for future.
| return self._transpiler_instance().get_trainer_program() | ||
|
|
||
| def get_pserver(self, ep): | ||
| return self._transpiler_instance().get_pserver_program(ep) |
There was a problem hiding this comment.
transpile will be called twice, we need to let _transpiler_instance call t.transpile only once.
There was a problem hiding this comment.
May not, after call get_trainer_program(), the program which inside transpiler would be changed.
| # block2: optimize pass | ||
| self.assertEqual([op.type for op in pserver.blocks[2].ops], | ||
| ["sum", "scale", "sgd"]) | ||
|
|
There was a problem hiding this comment.
startup also need to be checked.
There was a problem hiding this comment.
These asserts only test that the op type is equal, I think that you man assume that the op's inputs and outputs are verified when creating the program which will run InferShape
Fixed #10375