Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Inference data flow graph for analysis #10610

Closed
wants to merge 15 commits into from

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented May 13, 2018

Fixes: #10611

This is a part of the large PR #10459
It is based on the PR #10522 and should not merge before that PR.

Copy link
Contributor

@panyx0718 panyx0718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't seem to have any meaningful test in it? not sure how is this related to tensorrt integration...

std::pair<
std::vector<Node *>,
std::vector<
Node *>> static ExtractInputAndOutputOfSubGraph(std::vector<Node *>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format this line better?

// using NodesBFSIterator = xxx

// NodesBFSIterator nodes_begin();
// NodesBFSIterator nodes_end();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up?

* iterate in a graph defined Inverse order.
*/
template <typename GraphType>
struct Inverse {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used? If not, delete it?

@Xreki Xreki added the 预测 原名Inference,包含Capi预测问题等 label May 16, 2018
@Xreki Xreki added this to Integrate TensorRT in Inference Framework May 21, 2018
@Superjomn Superjomn closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
预测 原名Inference,包含Capi预测问题等
Projects
No open projects
Inference Framework
Integrate TensorRT
Development

Successfully merging this pull request may close these issues.

None yet

3 participants