-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Inference data flow graph for analysis #10610
Conversation
…/inference-framework
…/inference-framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't seem to have any meaningful test in it? not sure how is this related to tensorrt integration...
std::pair< | ||
std::vector<Node *>, | ||
std::vector< | ||
Node *>> static ExtractInputAndOutputOfSubGraph(std::vector<Node *> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format this line better?
// using NodesBFSIterator = xxx | ||
|
||
// NodesBFSIterator nodes_begin(); | ||
// NodesBFSIterator nodes_end(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean up?
* iterate in a graph defined Inverse order. | ||
*/ | ||
template <typename GraphType> | ||
struct Inverse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used? If not, delete it?
Fixes: #10611
This is a part of the large PR #10459
It is based on the PR #10522 and should not merge before that PR.