add inplace attribute to op_proto_maker #10665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzhwinter
commented
May 15, 2018
•
dzhwinter
commented
- add reused attribute to OpProto.
- change the related operator to use inplace attribute.
dzhwinter
commented
May 15, 2018
| @@ -115,7 +115,7 @@ class SumOpMaker : public framework::OpProtoAndCheckerMaker { | |||
| void Make() override { | |||
| AddInput("X", "(vector<Tensor>) The input tensors of sum operator.") | |||
| .AsDuplicable(); | |||
| AddOutput("Out", "(Tensor) The output tensor of sum operator."); | |||
| AddOutput("Out", "(Tensor) The output tensor of sum operator.").Reuse("X"); | |||
There was a problem hiding this comment.
In this case, Out should reuse the first Tensor memory of X(vector ), but we didn't have the sub-variable name of X.
dzhwinter
changed the title
|
The test only covers OpMaker, please add a runtime test for this feature. |
|
there are already a bunch of |
|
Have discussed this issue with @tonyyang-svail , we will move the in-place attribute into the ssa-graph framework. This PR is add an inplace attribute for every Operator in Python-side. |
JiayiFeng
reviewed
Jun 11, 2018
| AddOutput("Moment2Out", "(Tensor) Output second moment"); | ||
| AddOutput("ParamOut", "(Tensor) Output parameter").Reuse("Param"); | ||
| AddOutput("Moment1Out", "(Tensor) Output first moment").Reuse("Moment1"); | ||
| AddOutput("Moment2Out", "(Tensor) Output second moment").Reuse("Moment2"); |
There was a problem hiding this comment.
Is Moment2Out forced share memory with Moment2?
There was a problem hiding this comment.
It's not forced, is a suggestion will be get in memory optimizer in Python.
JiayiFeng
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.