Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix roi_pool op bug #10700

Merged
merged 8 commits into from
May 18, 2018
Merged

fix roi_pool op bug #10700

merged 8 commits into from
May 18, 2018

Conversation

baiyfbupt
Copy link
Contributor

@baiyfbupt baiyfbupt commented May 16, 2018

The bug is due to CUDA precision problem.
eg: it will store i = float(1) / float(3) as 0.333334, so after ceil(3 * i), the result is different from cpu(2 vs 1)
fix #10627

@baiyfbupt baiyfbupt requested a review from qingqing01 May 16, 2018 09:06
Copy link
Contributor

@dyning dyning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.CPU的预测值和GPU的预测值有diff
2.roi_pooling之前特征最大值和之后特征最大值不一致

@baiyfbupt baiyfbupt changed the title fix roi_pool op bug [WIP]fix roi_pool op bug May 16, 2018
@baiyfbupt baiyfbupt changed the title [WIP]fix roi_pool op bug fix roi_pool op bug May 17, 2018
Copy link
Contributor

@dyning dyning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,it's running ok.

Copy link
Contributor

@dyning dyning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPUROIPoolBackward function is also need fix.

@baiyfbupt
Copy link
Contributor Author

@dyning DONE

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@baiyfbupt baiyfbupt merged commit 67b8a30 into PaddlePaddle:develop May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROI pool层的GPU实现单测不过的问题
3 participants