feature/mul converter #10841
Merged
feature/mul converter #10841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/refine-opconverter
Superjomn
force-pushed
the
feature/mul_converter
branch
4 times, most recently
from
5b30915
to
4ce465c
Compare
Superjomn
force-pushed
the
feature/mul_converter
branch
from
0f958b3
to
120075e
Compare
luotao1
reviewed
May 29, 2018
| for (const auto& output : op_desc_->OutputArgumentNames()) { | ||
| std::vector<float> fluid_out; | ||
| std::vector<float> trt_out(200); | ||
| engine_->GetOutputInCPU(output, &trt_out[0], 200 * sizeof(float)); |
There was a problem hiding this comment.
200 是 memory space，没有特殊意义
There was a problem hiding this comment.
可以加个注释说明下为什么取200，会不会以后不够大。
| // Compare two output | ||
| ASSERT_FALSE(fluid_out.empty()); | ||
| for (size_t i = 0; i < fluid_out.size(); i++) { | ||
| EXPECT_LT(std::abs(fluid_out[i] - trt_out[i]), 0.001); |
| framework::OpDesc op_desc(op, nullptr, nullptr); | ||
| // Declare inputs | ||
| auto* input1 = engine_->GetITensor(op_desc.Input("X")[0]); | ||
| auto* input2 = engine_->GetITensor(op_desc.Input("Y")[0]); |
There was a problem hiding this comment.
Y这个值是weight，是存在scope里的，不是从GetITensor取的。
There was a problem hiding this comment.
这里 X，Y 的确是在 TensorRT 空间的，具体怎么把叫 X, Y 的 Tensor 从 Scope 拷贝到 TensorRT 里，是外层的其他逻辑去控制，ut里是一个framework去做这个
luotao1
approved these changes
May 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mul-op with a UT framework to test TensorRT op converter.