CustomReader #10872
Merged
CustomReader #10872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dev_CustomReader
… dev_CustomReader
reyoung
reviewed
May 25, 2018
| } | ||
| PADDLE_ENFORCE( | ||
| source_var_names_.size() == underlying_outs.size() && | ||
| sink_var_names_.size() == underlying_outs.size(), |
There was a problem hiding this comment.
sink_var_names maybe not equal with source_var_names.size()
reyoung
reviewed
May 25, 2018
| // The scope for CustomReader's sub-block should be independent and shouldn't | ||
| // be any other computation scope's child. Otherwise, data preprocessing and | ||
| // compution cannot be concurrent. | ||
| auto* scope = new framework::Scope(); |
There was a problem hiding this comment.
Well, it is no need to new Scope(). Just
Scope scope;is cool
reyoung
reviewed
May 25, 2018
| out->resize(sink_var_names_.size()); | ||
| for (size_t i = 0; i < sink_var_names_.size(); ++i) { | ||
| framework::Variable* var = scope->FindVar(sink_var_names_[i]); | ||
| PADDLE_ENFORCE_NOT_NULL(var); |
There was a problem hiding this comment.
Maybe fluid/operator/detail/safe_ref.h is good?
auto& tensor = detail::Ref(scope->FindVar(sink_var_names_[i])).Get<framework::LoDTensor>()
reyoung
reviewed
May 25, 2018
python/paddle/fluid/layers/io.py
Outdated
| source_lod_levels = self.underlying_reader.desc.lod_levels() | ||
| self.source_var_names = [] | ||
| source_vars = [] | ||
| for idx in xrange(len(source_shapes)): |
There was a problem hiding this comment.
Maybe more pythonic way
source_var_names = (unique_name("preprocessor_source") for _ in xrange(len(source_shapes)))
for var_name, shape, dtype, lod_level in zip(source_var_names, source_shapes, source_dtypes, source_lod_levels):
pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10873