Top K algorithm: parallel version #10941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozga-intel
force-pushed
the
mozga-intel/Top-K
branch
from
0d41c0c
to
d13f561
Compare
luotao1
reviewed
May 28, 2018
paddle/fluid/operators/top_k_op.h
Outdated
| @@ -55,6 +55,9 @@ class TopkKernel : public framework::OpKernel<T> { | |||
| // NOTE: eigen shape doesn't affect paddle tensor. | |||
| eg_input.reshape(flat2dims); | |||
|
|
|||
| #ifdef PADDLE_WITH_MKLDNN | |||
There was a problem hiding this comment.
how about use PADDLE_WITH_MKLML, since the speedup of top_k_op can be used in MKL scenario.
mozga-intel
force-pushed
the
mozga-intel/Top-K
branch
from
d13f561
to
d796008
Compare
luotao1
previously approved these changes
May 29, 2018
There was a problem hiding this comment.
LGTM! @mozga-intel Could you merge the latest develop code to pass the teamcity?
mozga-intel
force-pushed
the
mozga-intel/Top-K
branch
from
d796008
to
278f55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the Top-k algorithm of PaddlePaddle with omp.
Result: top_k 58 3813.27 33.239 69.4531 65.746
Result: top_k 58 92.8446 0.889532 5.54269 1.60077