Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fluid_guide #10961

Merged
merged 2 commits into from
May 28, 2018
Merged

add fluid_guide #10961

merged 2 commits into from
May 28, 2018

Conversation

weixing02
Copy link
Collaborator

Add fluid_guide to fluid/get_started, image display error fixed. will polish this doc in the other PR.

@weixing02 weixing02 requested a review from shanyi15 May 28, 2018 02:40
@weixing02
Copy link
Collaborator Author

polish fluid_guide, fix all deadlinks and table display errors.

@luotao1
Copy link
Contributor

luotao1 commented May 28, 2018

https://github.com/weixing02/Paddle/blob/9db25364ab6d1840c3b574a4c45114393f2a004a/doc/fluid/getstarted/Developer's_Guide_to_Paddle_Fluid.md 图片都不能正常显示。

@weixing02
Copy link
Collaborator Author

因为图片也是与这个PR一起上传的，所以现在暂时还无法正常显示，等merge之后就可以显示的~

shanyi15
shanyi15 approved these changes May 28, 2018
View reviewed changes
Copy link
Collaborator

@shanyi15 shanyi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanyi15 shanyi15 merged commit 34e093a into PaddlePaddle:develop May 28, 2018
@luotao1
Copy link
Contributor

luotao1 commented May 28, 2018

https://github.com/PaddlePaddle/Paddle/blob/develop/doc/fluid/getstarted/Developer's_Guide_to_Paddle_Fluid.md 还是没有显示图片。

  • 官网上没有显示这个文档。

@weixing02
Copy link
Collaborator Author

恩恩 有一个img链接错误，修改之后重新提了PR #10979 ，并在index_*.rst中加入了这篇文档链接。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanyi15 shanyi15 shanyi15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weixing02 @luotao1 @shanyi15