Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random crop op #10970

Merged
merged 15 commits into from
May 30, 2018
Merged

Conversation

JiayiFeng
Copy link
Collaborator

No description provided.

@JiayiFeng JiayiFeng requested a review from reyoung May 28, 2018 10:46
size_t offset_i = offsets[i];

if (i == rank - 1) {
PADDLE_ENFORCE(x_stride == 1 && out_stride == 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PADDLE_ENFORCE does not support as a device function. Maybe we should use PADDLE_ASSERT

Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/codestyle/docstring_checker.pyc should not be commited.

Please use git rebase to remove it from history.

@reyoung reyoung merged commit 1490551 into PaddlePaddle:develop May 30, 2018
@JiayiFeng JiayiFeng deleted the dev_add_random_crop_op branch May 30, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants