Fix and optimize async distribute lookup table #10973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
changed the title
jacquesqiao
changed the title
typhoonzero
reviewed
May 29, 2018
| @@ -731,6 +741,15 @@ def _clone_var(block, var, persistable=True): | |||
| type="sum", | |||
| inputs={"X": table_grad_list}, | |||
| outputs={"Out": [grad_var]}) | |||
| else: | |||
There was a problem hiding this comment.
In https://github.com/PaddlePaddle/Paddle/pull/10973/files#diff-3a23ecb6a98b666c84525f3f6fcd2bb6R729, table_grad_list maybe confused with self. table_grad_list, I think maybe better to store in different name, or seperate trainer side and server side transpile processes.
There was a problem hiding this comment.
follow comment, change to trainer_side_table_grad_list and pserver_side_table_grad_list
| @@ -678,7 +688,7 @@ def _create_prefetch_block(self, pserver_index, pserver_program, | |||
| return prefetch_block | |||
|
|
|||
| def _create_table_optimize_block(self, pserver_index, pserver_program, | |||
| pre_block_idx): | |||
| pre_block_idx, grad_to_block_id): | |||
| def _clone_var(block, var, persistable=True): | |||
There was a problem hiding this comment.
Can use block.clone_variable instead?
…qiao/Paddle into fix-prefetch
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project: #10868