Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of inputs in infer() of label_semantic example (new API) #10993

Merged
merged 1 commit into from
May 29, 2018
Merged

Fix order of inputs in infer() of label_semantic example (new API) #10993

merged 1 commit into from
May 29, 2018

Conversation

sidgoyal78
Copy link
Contributor

@sidgoyal78 sidgoyal78 commented May 29, 2018 •
edited
Loading

This is a minor fix to avoid inconsistency related to the feed_order in train and infer methods of the label_semantic_roles example.

@sidgoyal78 sidgoyal78 requested a review from daming-lu May 29, 2018 05:21
daming-lu
daming-lu approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@daming-lu daming-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤴

@sidgoyal78 sidgoyal78 merged commit 88aa2d8 into PaddlePaddle:develop May 29, 2018
@sidgoyal78 sidgoyal78 deleted the fix_label_semantic_order branch May 29, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daming-lu daming-lu daming-lu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidgoyal78 @daming-lu