Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split reduce op into multiple libraries, accelerate the compiling #11029

Merged
merged 10 commits into from
Jun 7, 2018

Conversation

dzhwinter
Copy link
Contributor

@dzhwinter dzhwinter commented May 30, 2018

fix #10874 #9306

before split reduce op into multiple operators

real	16m35.665s
user	15m56.777s
sys	0m50.414s

after

@dzhwinter
Copy link
Contributor Author

The reduce op will have performance problems because it uses a lot of broadcast, which is extremely slow. And the template needs a cleanup.

@reyoung
Copy link
Collaborator

reyoung commented May 30, 2018

I think we might rewrite this function by not using template generation too much. Splitting them into files just a temporary solution.

@dzhwinter
Copy link
Contributor Author

Yes. I can't agree with you more. I have clarified that the template needs a cleanup and the broadcast issues, so we need to rewrite the reduce op. Just leave that job when we have more spare time.

Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@dzhwinter dzhwinter merged commit d48172f into PaddlePaddle:develop Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce op compile slowly
2 participants