Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better profiler and benchmark #11036

Merged
merged 3 commits into from
May 30, 2018
Merged

Conversation

panyx0718
Copy link
Contributor

@panyx0718 panyx0718 commented May 30, 2018

  1. fix fluid_benchmark train_parallel() wrong trainer_id (always 0 trainer_id in train_parallel()).
  2. fix profiler int value overflow
  3. more flexible profiler python API

image

try it with

#!/bin/bash

PADDLE_TRAINING_ROLE=PSERVER PADDLE_PSERVER_PORT=7164 PADDLE_PSERVER_IPS=127.0.0.1 PADDLE_TRAINERS=2 PADDLE_CURRENT_IP=127.0.0.1 PADDLE_TRAINER_ID=0 python ../Paddle/benchmark/fluid/fluid_benchmark.py --model resnet --device GPU --update_method pserver --iterations=10000 &

sleep 15

CUDA_VISIBLE_DEVICES=0,1 PADDLE_TRAINING_ROLE=TRAINER PADDLE_PSERVER_PORT=7164 PADDLE_PSERVER_IPS=127.0.0.1 PADDLE_TRAINERS=2 PADDLE_CURRENT_IP=127.0.0.1 PADDLE_TRAINER_ID=0 python ../Paddle/benchmark/fluid/fluid_benchmark.py --model resnet --device GPU --update_method pserver --iterations=10000 --gpus 2 --profile &

CUDA_VISIBLE_DEVICES=4,5 PADDLE_TRAINING_ROLE=TRAINER PADDLE_PSERVER_PORT=7164 PADDLE_PSERVER_IPS=127.0.0.1 PADDLE_TRAINERS=2 PADDLE_CURRENT_IP=127.0.0.1 PADDLE_TRAINER_ID=1 python ../Paddle/benchmark/fluid/fluid_benchmark.py --model resnet --device GPU --update_method pserver --iterations=10000 --gpus 2 --profile &

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this fix!

@panyx0718 panyx0718 merged commit 35d5b1b into PaddlePaddle:develop May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants