support recordio in dist train #11066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
May 31, 2018
| @@ -65,20 +65,22 @@ class CreateRecordIOReaderOp : public framework::OperatorBase { | |||
| static_cast<int>(shape_concat.size()), | |||
| "The accumulate of all ranks should be equal to the " | |||
| "shape concat's length."); | |||
| std::string filename = Attr<std::string>("filename"); | |||
| auto filenames = Attr<std::vector<std::string>>("filenames"); | |||
There was a problem hiding this comment.
fluid.layers.open_files should do the job, please see test_multi_file_reader.py
There was a problem hiding this comment.
Seems open_files_op can only deal with the normal files.
There was a problem hiding this comment.
open_files_op can deal with RecordIO file. Just make sure that file names end with '.recordio'
typhoonzero
reviewed
Jun 1, 2018
| as follows: | ||
|
|
||
| ```python | ||
| reader = paddle.batch(mnist.train(), batch_size=1) |
There was a problem hiding this comment.
Need to tell users why batch_size=1 here, and for fix batch_size we can gain performance?
| fluid.recordio_writer.convert_reader_to_recordio_file('./mnist.recordio', reader, feeder) | ||
| ``` | ||
|
|
||
| The above codes would generate a RecordIO `./mnist.recordio` on your host. |
|
|
||
| ## Use the RecordIO files in Distributed Training | ||
|
|
||
| 1. generate multiple RecordIO files |
There was a problem hiding this comment.
The number tags seem not showing correctly when viewing.
typhoonzero
reviewed
Jun 4, 2018
| counter += 1 | ||
| lines = [] | ||
| f_idx += 1 | ||
| return counter |
There was a problem hiding this comment.
Remove tools/codestyle/docstring_checker.pyc file please
There was a problem hiding this comment.
Done, and add it to gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #11024