MKLDNN layout: Support for pool operator #11101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2018
Merged
mozga-intel
force-pushed
the
mozga-intel/Pool_mkldnn_layout
branch
from
c6bf91f
to
36031cb
Compare
tensor-tang
reviewed
Jun 11, 2018
| @@ -94,16 +103,17 @@ class PoolMKLDNNOpKernel : public paddle::framework::OpKernel<T> { | |||
| auto pool_p = | |||
| std::static_pointer_cast<pooling_forward>(dev_ctx.GetBlob(key_pool_p)); | |||
| if (pool_p == nullptr) { | |||
| // TODO(pzelazko-intel): support more formats | |||
| auto src_md = platform::MKLDNNMemDesc( | |||
| src_tz, platform::MKLDNNGetDataType<T>(), input_format); | |||
There was a problem hiding this comment.
input->format().
input_format is only used once.
tensor-tang
reviewed
Jun 11, 2018
| @@ -267,35 +302,74 @@ class PoolMKLDNNGradOpKernel : public paddle::framework::OpKernel<T> { | |||
| auto pool_bwd_pd = mkldnn::pooling_backward::primitive_desc( | |||
| pool_bwd_desc, mkldnn_engine, *pool_pd); | |||
|
|
|||
| // reorder between user_diff_dst and pool diff_dst if needed | |||
| diff_dst_memory = std::make_shared<memory>(user_diff_dst_memory); | |||
There was a problem hiding this comment.
We recommend unique_ptr, maybe next time you can change all of them.
tensor-tang
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for supports of the mkldnn’s layout.
Please have a look at this pool operator supported by the MKLDNN’s layout and assess if we can keep this design of the code.
This code uses the implementation of layout which is available in the last pull-request. Therefore some of the function in this code are not available in this pull-request, but are available here
This version of code can be merged into the main branch when the pull-request with layout is accepted.
The concept of splits of the long code was proposed by @luotao1
Pull-request is related to #11040