Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build error on mac #11134

Merged
merged 2 commits into from
Jun 4, 2018
Merged

fix build error on mac #11134

merged 2 commits into from
Jun 4, 2018

Conversation

jacquesqiao
Copy link
Member 

/Users/qiaolongfei/project/paddle/paddle/fluid/operators/detail/grpc_server.h:75:15: error: private field 'barrier_cond_step_' is not used [-Werror,-Wunused-private-field]
  mutable int barrier_cond_step_;

/Users/qiaolongfei/project/paddle/paddle/fluid/operators/listen_and_serv_op.cc:225:29: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
  h->SetPrefetchPreparedCtx(std::move(
                            ^
/Users/qiaolongfei/project/paddle/paddle/fluid/operators/listen_and_serv_op.cc:225:29: note: remove std::move call here
  h->SetPrefetchPreparedCtx(std::move(
                            ^~~~~~~~~~

gongweibao
gongweibao requested changes Jun 3, 2018
View reviewed changes
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

paddle/fluid/operators/detail/grpc_server.h Outdated
@@ -71,8 +71,8 @@ class AsyncGRPCServer final : public RPCServer {
std::unique_ptr<::grpc::Server> server_;

// condition of the sub program
std::mutex barrier_mutex_;
mutable int barrier_cond_step_;
// std::mutex barrier_mutex_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be deleted.

gongweibao
gongweibao approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacquesqiao jacquesqiao merged commit c7002f5 into PaddlePaddle:develop Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongweibao gongweibao gongweibao approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacquesqiao @gongweibao