Trainer send term signal #11220
Merged
Trainer send term signal #11220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 5, 2018 17:34
… trainer_send_term_signal
… trainer_send_term_signal
… trainer_send_term_signal
… trainer_send_term_signal
… trainer_send_term_signal
gongweibao
previously approved these changes
Jun 11, 2018
| @@ -52,6 +52,9 @@ bool RequestSendHandler::Handle(const std::string& varname, | |||
| if (varname == BATCH_BARRIER_MESSAGE) { | |||
| VLOG(3) << "sync: recv batch barrier message"; | |||
| rpc_server_->IncreaseBatchBarrier(kRequestSend); | |||
| } else if (varname == COMPLETE_MESSAGE) { | |||
| VLOG(3) << "sync: recv complete message"; | |||
| rpc_server_->DecreaseClientNum(); | |||
|
Only |
|
@gongweibao You were right, we may need to add trainer id to the request when we want to make all RPC calls retriable. |
… trainer_send_term_signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11077
Call
exe.executor.complete()to tell pserver to mark current trainer as finished.