bugfix/trt op with kernel #11408
Closed
bugfix/trt op with kernel #11408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Superjomn
commented
Jun 12, 2018
•
Superjomn
commented
- add one FC layer for benchmark
- TODO add more layers
- fixed a bug, about not share the TRT engine for all the TRT engine op kernels.
luotao1
reviewed
Jun 14, 2018
| return engines_.at(name).get(); | ||
| } | ||
|
|
||
| // Create or get an engine called `key` |
There was a problem hiding this comment.
Create an engine called name
| mutable inference::tensorrt::TensorRTEngine* engine_{nullptr}; | ||
| mutable int max_batch_{0}; | ||
| // TODO(Superjomn) replace this stream with context's stream. | ||
| // mutable cudaStream_t stream_; |
There was a problem hiding this comment.
原来声明的stream_，engine_， max_batch_都不要了？
There was a problem hiding this comment.
对，之前那些会出现 bug：kernel 每个 type 全局只有一份，所以不能有 member。
This comment has been minimized.
This comment has been minimized.
… feature/trt_manul_benchmark
…rjomn/Paddle into feature/trt_manul_benchmark
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.