Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conv3d/pool3d/conv3d_trans Python API #11437

Merged
merged 5 commits into from
Jun 15, 2018
Merged

Add conv3d/pool3d/conv3d_trans Python API #11437

merged 5 commits into from
Jun 15, 2018

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Jun 13, 2018 •
edited

fix #11433

typhoonzero
typhoonzero reviewed Jun 13, 2018
View reviewed changes
python/paddle/fluid/layers/nn.py
act=None,
name=None):
"""
**Convlution3D Layer**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use @templatedoc to avoid copying comments, see yu laoshi's PR: #11308

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typhoonzero Sound great!
But Convlution Layer and Convlution Op are not completely equal.
The equation of Convlution Layer is $Out = \sigma (W \ast X + b)$. But Convlution Op's is $Out = W \ast X$. So their comment should not be the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

typhoonzero
typhoonzero previously approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++, 2d and 3d layers have a lot common codes, we may need to put them to some base class then.

typhoonzero
typhoonzero approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@chengduoZH chengduoZH merged commit f4dce56 into PaddlePaddle:develop Jun 15, 2018
@chengduoZH chengduoZH mentioned this pull request Jun 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3D conv is needed in python-api
2 participants
@chengduoZH @typhoonzero