Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compiler error in contrib/tape #11466

Merged
merged 2 commits into from
Jun 14, 2018
Merged

fix compiler error in contrib/tape #11466

merged 2 commits into from
Jun 14, 2018

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jun 14, 2018 •
edited
Loading

fix #11465
fix #11467 (set serial for parallel test)

@luotao1 luotao1 requested a review from tensor-tang June 14, 2018 06:58
@tensor-tang tensor-tang mentioned this pull request Jun 14, 2018
Merged
chengduoZH
chengduoZH previously approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Superjomn
Superjomn approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reyoung
reyoung approved these changes Jun 14, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@luotao1 luotao1 merged commit 0b3d7f1 into PaddlePaddle:develop Jun 14, 2018
@luotao1 luotao1 deleted the teamcity branch June 14, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superjomn Superjomn Superjomn approved these changes

@reyoung reyoung reyoung approved these changes

@chengduoZH chengduoZH chengduoZH left review comments

@tensor-tang tensor-tang Awaiting requested review from tensor-tang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_parallel_executor_crf hang teamcity fails
4 participants
@luotao1 @Superjomn @reyoung @chengduoZH