Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dist ut #11470

Merged
merged 2 commits into from
Jun 15, 2018
Merged

Fix dist ut #11470

merged 2 commits into from
Jun 15, 2018

Conversation

typhoonzero
Copy link
Contributor

@typhoonzero typhoonzero commented Jun 14, 2018 •
edited
Loading

Fix #11235

Yancey1989
Yancey1989 reviewed Jun 15, 2018
View reviewed changes
python/paddle/fluid/tests/unittests/test_listen_and_serv_op.py

# raise SIGTERM to pserver
os.kill(pid, signal.SIGTERM)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO comment here?

If we use signal.SIGKILL instead of signal.SIGTERM, it means SignalHandler::StopAndExit in listen_and_serv_op does not effect, we need to fix it in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add an issue about it.

@typhoonzero typhoonzero mentioned this pull request Jun 15, 2018
Closed
Yancey1989
Yancey1989 approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luotao1 luotao1 merged commit 5ea039b into PaddlePaddle:develop Jun 15, 2018
@typhoonzero typhoonzero deleted the fix_unitests branch June 15, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yancey1989 Yancey1989 Yancey1989 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@typhoonzero @Yancey1989 @luotao1