Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for while and piecewise_decay op #11511

Merged
merged 4 commits into from
Jun 15, 2018
Merged

Add doc for while and piecewise_decay op #11511

merged 4 commits into from
Jun 15, 2018

Conversation

panyx0718
Copy link
Contributor

@panyx0718 panyx0718 commented Jun 15, 2018 •
edited
Loading

image

image

@luotao1
Copy link
Contributor

luotao1 commented Jun 15, 2018

这个例子是不是过长，使用Developer's_Guide_to_Paddle_Fluid.md#while_op 例子更清晰点
image

介绍部分可参考：https://github.com/PaddlePaddle/Paddle/blob/develop/doc/fluid/getstarted/Developer's_Guide_to_Paddle_Fluid.md#while_op

reyoung
reyoung previously approved these changes Jun 15, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not perfect, but better than before.

@panyx0718
Copy link
Contributor Author

Done

luotao1
luotao1 previously approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyx0718 panyx0718 changed the title Add doc for while op Add doc for while and piecewise_decay op Jun 15, 2018
@luotao1
Copy link
Contributor

luotao1 commented Jun 15, 2018 •
edited
Loading

例子缺少Examples，>>>这些需要去掉吧。
piecewise decay可以解释的更详细一点么

@panyx0718
Copy link
Contributor Author

好了

luotao1
luotao1 approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyx0718 panyx0718 merged commit dadbe45 into PaddlePaddle:develop Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@reyoung reyoung reyoung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panyx0718 @luotao1 @reyoung