refine the initial cpu memory flag for mkldnn #11525
Conversation
|
When enabled WITH_MKLDNN:
When set from env:
|
paddle/fluid/platform/cpu_info.cc
Outdated
| "Default initial 500MB of CPU memory for PaddlePaddle, in MD unit."); | ||
| DEFINE_uint64(initial_cpu_memory_in_mb, | ||
| #ifdef PADDLE_WITH_MKLDNN | ||
| 1000, |
There was a problem hiding this comment.
Add some comments to tell why 1000 works.
There was a problem hiding this comment.
Actually, I am not sure why this exactly 1000 number may works.
I was trying to give more space, here gives 2x of original, for MKLDNN according to the comment from mozga-intel.
And that's why I add @mozga-intel to help to review.
Please @mozga-intel, could you please help check if it's this enough.
BTW, I add this flag to env, so users can change this from env if this default 1000MB is not enough.
There was a problem hiding this comment.
@tensor-tang Of course.
There was a problem hiding this comment.
@tensor-tang IMO I think that 1000MB of space of memory is too small. The good result is obtained when the memory is greater than 5000 MB
There was a problem hiding this comment.
OK, thanks @mozga-intel, I will replace it with 5000 MB.
resolve #11481