Fix kube jobs generator's bugs. #11557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
reviewed
Jun 19, 2018
benchmark/fluid/kube_gen_job.py
Outdated
| envs.append({"name": "ENTRY", "value": args.entry}) | ||
| envs.append({"name": "PADDLE_INIT_PORT", "value": str(args.port)}) | ||
| #envs.append({"name": "PADDLE_INIT_PORT", "value": str(args.port)}) |
There was a problem hiding this comment.
Delete the comment code.
benchmark/fluid/Dockerfile
Outdated
|
|
||
| RUN sh -c 'echo "import paddle.v2 as paddle\npaddle.dataset.cifar.train10()\npaddle.dataset.flowers.fetch()" | python' | ||
| RUN sh -c 'echo "import paddle.v2 as paddle\npaddle.dataset.mnist.train()\npaddle.dataset.mnist.test()\npaddle.dataset.imdb.fetch()" | python' | ||
| RUN sh -c 'echo "import paddle.v2 as paddle\npaddle.dataset.imikolov.fetch()" | python' | ||
| RUN pip uninstall -y paddlepaddle && mkdir /workspace | ||
|
|
||
| ADD *.whl / |
There was a problem hiding this comment.
Don't move ADD *.whl /? We can cache ADD https://raw.githubusercontent.com/PaddlePaddle/cloud/develop/docker/paddle_k8s /usr/bin .
typhoonzero
reviewed
Jun 20, 2018
benchmark/fluid/Dockerfile
Outdated
| @@ -1,11 +1,17 @@ | |||
| FROM nvidia/cuda:9.0-cudnn7-devel-ubuntu16.04 | |||
|
|
|||
| ARG UBUNTU_MIRROR | |||
There was a problem hiding this comment.
Not all versions of docker support ARG. And change one line of Dockerfile seems easier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.