Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bilinear interp supporting for uint8 #11576

Merged
merged 5 commits into from
Jun 20, 2018

Conversation

JiayiFeng
Copy link
Collaborator

Makes bilinear_interp_op supporting resizing uint8 images directly.

reyoung
reyoung previously approved these changes Jun 20, 2018
T w1lambda = ratio_w * j - w;
T w2lambda = 1 - w1lambda;
float w1lambda = ratio_w * j - w;
float w2lambda = 1.f - w1lambda;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最好为T=uint8加个单测吧? 你确定line75没问题么?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恩,已经为75行加上了static_cast,并且加上了单测

Copy link
Contributor

@wanghaoshuang wanghaoshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiayiFeng JiayiFeng merged commit 6e1c48d into PaddlePaddle:develop Jun 20, 2018
@JiayiFeng JiayiFeng deleted the dev_refine_bilinear_interp branch June 20, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants