Add design doc of Python data feeding #11592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiayiFeng
reviewed
Jun 20, 2018
| size_t size() const; // Get the current size of the queue | ||
| size_t capacity() const; // Get the capacity of the queue | ||
| bool is_full() const; | ||
| bool is_empty() const; |
There was a problem hiding this comment.
Are these two functions necessary?
JiayiFeng
reviewed
Jun 20, 2018
| // Use pybind11::gil_scoped_release to release GIL of Python | ||
| std::vector<framework::LoDTensor> pop(); | ||
| private: | ||
| BlockingQueue<std::vector<framework::LoDTensor>> queue_; |
There was a problem hiding this comment.
We have more than one BlockingQueue in Fluid, so please use a namespace to specify which one you are using.
sneaxiy
force-pushed
the
python_data_feeding
branch
4 times, most recently
from
d618421
to
6de7380
Compare
sneaxiy
force-pushed
the
python_data_feeding
branch
from
6de7380
to
19fd071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.