Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move dist codes from operaotrs/detail to operators/distributed #11603

Merged
merged 2 commits into from
Jun 20, 2018
Merged

move dist codes from operaotrs/detail to operators/distributed #11603

merged 2 commits into from
Jun 20, 2018

Conversation

Yancey1989
Copy link
Contributor

Fixed #11582

luotao1
luotao1 reviewed Jun 20, 2018
View reviewed changes
paddle/fluid/operators/CMakeLists.txt Outdated
if(WITH_DISTRIBUTE)
add_subdirectory(distributed)

set(DISTRIBUTE_DEPS "")
if(WITH_GRPC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about use a common cmake function to package

op_library(prefetch_op DEPS ${DISTRIBUTE_DEPS})
set_source_files_properties(prefetch_op.cc PROPERTIES COMPILE_FLAGS ${DISTRIBUTE_COMPILE_FLAGS})

to simply line 198-209

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

luotao1
luotao1 approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@Yancey1989 Yancey1989 merged commit c413c46 into PaddlePaddle:develop Jun 20, 2018
@Yancey1989 Yancey1989 deleted the rename_details_folder branch June 20, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@panyx0718 panyx0718 Awaiting requested review from panyx0718

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yancey1989 @luotao1