Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concat compile warning #11607

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Jun 20, 2018

Fix concat compile warning

../paddle/fluid/operators/math/concat.cc: In instantiation of ‘void paddle::operators::math::ConcatGradFunctor<paddle::platform::CPUDeviceContext, T>::operator()(const paddle::platform::CPUDeviceContext&, const paddle::framework::Tensor&, const std::vector<const paddle::framework::Tensor*>&, int, std::vector<paddle::framework::Tensor*>*) [with T = int]’:
../paddle/fluid/operators/math/concat.cc:118:16:   required from here
../paddle/fluid/operators/math/concat.cc:96:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (size_t k = 0; k < input_rows; ++k) {
                          ^
../paddle/fluid/operators/math/concat.cc:99:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       for (int j = 0; j < num; ++j) {
                         ^
../paddle/fluid/operators/math/concat.cc: In instantiation of ‘void paddle::operators::math::ConcatGradFunctor<paddle::platform::CPUDeviceContext, T>::operator()(const paddle::platform::CPUDeviceContext&, const paddle::framework::Tensor&, const std::vector<const paddle::framework::Tensor*>&, int, std::vector<paddle::framework::Tensor*>*) [with T = long int]’:
../paddle/fluid/operators/math/concat.cc:119:16:   required from here
../paddle/fluid/operators/math/concat.cc:96:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (size_t k = 0; k < input_rows; ++k) {
                          ^
../paddle/fluid/operators/math/concat.cc:99:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       for (int j = 0; j < num; ++j) {
                         ^
../paddle/fluid/operators/math/concat.cc: In instantiation of ‘void paddle::operators::math::ConcatGradFunctor<paddle::platform::CPUDeviceContext, T>::operator()(const paddle::platform::CPUDeviceContext&, const paddle::framework::Tensor&, const std::vector<const paddle::framework::Tensor*>&, int, std::vector<paddle::framework::Tensor*>*) [with T = float]’:
../paddle/fluid/operators/math/concat.cc:120:16:   required from here
../paddle/fluid/operators/math/concat.cc:96:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (size_t k = 0; k < input_rows; ++k) {
                          ^
../paddle/fluid/operators/math/concat.cc:99:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       for (int j = 0; j < num; ++j) {
                         ^
../paddle/fluid/operators/math/concat.cc: In instantiation of ‘void paddle::operators::math::ConcatGradFunctor<paddle::platform::CPUDeviceContext, T>::operator()(const paddle::platform::CPUDeviceContext&, const paddle::framework::Tensor&, const std::vector<const paddle::framework::Tensor*>&, int, std::vector<paddle::framework::Tensor*>*) [with T = double]’:
../paddle/fluid/operators/math/concat.cc:121:16:   required from here
../paddle/fluid/operators/math/concat.cc:96:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (size_t k = 0; k < input_rows; ++k) {
                          ^
../paddle/fluid/operators/math/concat.cc:99:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       for (int j = 0; j < num; ++j) {

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit bfe5dc6 into PaddlePaddle:develop Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants