Fix kill fail bug #11635
Fix kill fail bug #11635
Conversation
2. Change SIGKILL to SIGINT and SIGTERM
… up which is caused by the opencv-python package missing
|
@luotao1 Could you please take a look at this? The missing of According to the issue, how could I check that this pr works for u in the flower dataset? |
| @@ -76,7 +76,8 @@ RUN easy_install -U pip && \ | |||
| pip install sphinx-rtd-theme==0.1.9 recommonmark | |||
|
|
|||
| RUN pip install pre-commit 'ipython==5.3.0' && \ | |||
| pip install 'ipykernel==4.6.0' 'jupyter==1.0.0' | |||
| pip install 'ipykernel==4.6.0' 'jupyter==1.0.0' && \ | |||
| pip install opencv-python | |||
There was a problem hiding this comment.
pip install opencv-python，和apt-get install 并不冲突， @velconia 已经测过，可以正常加载flowers数据集。
There was a problem hiding this comment.
为什么pip install opencv-python会影响进程terminate呢？
| @@ -22,7 +22,7 @@ | |||
| function print_usage() { | |||
There was a problem hiding this comment.
paddle_build.sh的gen_dockerfile函数里面需要pip install 么？不然latest等镜像没有这个包。
There was a problem hiding this comment.
gen_dockerfile 里添加了 pip install /*.whl, 我理解会把 paddle python 依赖的所有包都加上, opencv-python也是其中之一
There was a problem hiding this comment.
@typhoonzero could you please take a look at this?
There was a problem hiding this comment.
whl installs packages here, in Paddle/python/setup.py.in
if '${CMAKE_SYSTEM_PROCESSOR}' not in ['arm', 'armv7-a', 'aarch64']:
setup_requires+=['opencv-python']
| foreach(TEST_OP ${TEST_OPS}) | ||
| py_test_modules(${TEST_OP} MODULES ${TEST_OP}) | ||
| endforeach(TEST_OP) | ||
| py_test_modules(test_warpctc_op MODULES test_warpctc_op ENVS FLAGS_warpctc_dir=${WARPCTC_LIB_DIR} SERIAL) | ||
| py_test_modules(test_dist_train MODULES test_dist_train SERIAL) | ||
| py_test_modules(test_parallel_executor_crf MODULES test_parallel_executor_crf SERIAL) | ||
| py_test_modules(test_parallel_executor_fetch_feed MODULES test_parallel_executor_fetch_feed SERIAL) | ||
| # (DONE) tests that need to be done in fixed timeout |
There was a problem hiding this comment.
Can remove this comment
* 1. Remove PYTHON_FLAGS from paddle_build.sh in paddlepaddle/paddle:latest-dev * 1. Add PYTHON_FLAGS back 2. Change SIGKILL to SIGINT and SIGTERM * 1. Add setup.py.in back * 1. add pip install open-cv in Dockerfile to avoid libusb_exit hanging up which is caused by the opencv-python package missing * 1. Add the && \ to line above * 1. Remove the notice comment
This close #11509