Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python Callstacks when Op::Run error #12759

Merged
merged 11 commits into from Aug 23, 2018
Merged

Add Python Callstacks when Op::Run error #12759

merged 11 commits into from Aug 23, 2018

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Aug 17, 2018

No description provided.

@reyoung reyoung requested a review from chenwhql August 17, 2018 04:49
chenwhql
chenwhql reviewed Aug 17, 2018
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can make the python callstack info's format be consistent with python original traceback format, I think users are more accustomed to this format. And extract_stack() line no need to tell users.

image

chenwhql
chenwhql previously approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@reyoung reyoung merged commit b2df170 into PaddlePaddle:develop Aug 23, 2018
guochaorong added a commit that referenced this pull request Aug 23, 2018
@guochaorong
Revert "Add Python Callstacks when Op::Run error (#12759)"
1f27027 
This reverts commit b2df170.
panyx0718 added a commit that referenced this pull request Aug 24, 2018
@panyx0718
Merge pull request #12903 from PaddlePaddle/revert-12759
fd1875b 
Revert "Add Python Callstacks when Op::Run error (#12759)"
reyoung added a commit to reyoung/Paddle that referenced this pull request Aug 27, 2018
@reyoung
Revert "Revert "Add Python Callstacks when Op::Run error (PaddlePaddl…
906c28c 
…e#12759)""

This reverts commit 1f27027.
reyoung added a commit to reyoung/Paddle that referenced this pull request Sep 4, 2018
@reyoung
Revert "Revert "Add Python Callstacks when Op::Run error (PaddlePaddl…
cda7842 
…e#12759)""

This reverts commit 1f27027.
reyoung added a commit that referenced this pull request Sep 25, 2018
@reyoung
Merge pull request #13201 from reyoung/revert_callstack
21bb9e9 
Revert "Revert "Add Python Callstacks when Op::Run error (#12759)""
reyoung added a commit that referenced this pull request Sep 26, 2018
@reyoung
Revert "Revert "Revert "Add Python Callstacks when Op::Run error (#12759
ee00183 
)"""
reyoung added a commit to reyoung/Paddle that referenced this pull request Sep 28, 2018
@reyoung
Revert "Revert "Revert "Add Python Callstacks when Op::Run error (Pad…
2126ac3 
…dlePaddle#12759)"""

test=develop
wopeizl pushed a commit to wopeizl/Paddle that referenced this pull request Dec 19, 2018
@reyoung @wopeizl
cherry-pick the PaddlePaddle#12759
6657947 
Add Python Callstacks when Op::Run error
wopeizl pushed a commit to wopeizl/Paddle that referenced this pull request Dec 21, 2018
@reyoung @wopeizl
cherry-pick the PaddlePaddle#12759
175b22f 
Add Python Callstacks when Op::Run error
test=develop
wopeizl pushed a commit to wopeizl/Paddle that referenced this pull request Dec 24, 2018
@reyoung @wopeizl
cherry-pick the PaddlePaddle#12759
2838c1a 
Add Python Callstacks when Op::Run error
wopeizl pushed a commit to wopeizl/Paddle that referenced this pull request Dec 25, 2018
@reyoung @wopeizl
cherry-pick the PaddlePaddle#12759
b75135c 
Add Python Callstacks when Op::Run error
wopeizl added a commit to wopeizl/Paddle that referenced this pull request Dec 25, 2018
@wopeizl
cherry-pick the PaddlePaddle#12759
7f6d8ac 
test=develop
wopeizl added a commit that referenced this pull request Dec 26, 2018
@wopeizl
Merge pull request #15035 from wopeizl/debug/improvement1
09bd8fa 
cherry-pick the #12759
wopeizl added a commit to wopeizl/Paddle that referenced this pull request Dec 26, 2018
@wopeizl
Revert "cherry-pick the PaddlePaddle#12759"
2388d0e 
test=develop

This reverts commit 7f6d8ac.
panyx0718 added a commit that referenced this pull request Dec 27, 2018
@panyx0718
Merge pull request #15071 from wopeizl/revert/15035
71a4a8e 
Revert "cherry-pick the #12759"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reyoung @chenwhql