New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize while_op for test #14764
Merged
Merged
Optimize while_op for test #14764
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7e02fc1
Simplify the compare op for CPU.
Xreki b65760b
Use asynchronous tensor copy in reshape_op's kernel.
Xreki 4473895
Optimize while_op for test, avoiding creating variables every time.
Xreki 9619043
Merge branch 'develop' into core_opt_while_op
Xreki 3fda0b1
Enable the cache of kernel type and kernel function.
Xreki c3963f6
Merge branch 'develop' into core_opt_while_op
Xreki aec4e29
Enable profiling with gperftools.
Xreki 4d1b624
Remove flags for testing, and fix the linking error.
Xreki b2aa81a
Merge branch 'develop' into core_opt_while_op
Xreki 6c76cdd
Delete the codes of ChooseKernel.
Xreki d18af8b
Merge branch 'develop' into core_opt_while_op
Xreki 375454a
Fix bug when preparing ExecutorPrepareContext for while_op.
Xreki ac191ba
Merge branch 'develop' into core_opt_while_op
Xreki b26bd96
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
Xreki c4486fc
Merge branch 'develop' into core_opt_while_op
Xreki 1286fd0
Merge branch 'develop' into core_opt_while_op
Xreki 0944f7f
Fix missing depending on grpc libraries.
Xreki b52b770
Merge branch 'develop' into core_opt_while_op
Xreki 135c17c
Merge branch 'develop' into core_opt_while_op
Xreki 8476f7c
Remove the redundant print.
Xreki ad927fd
Merge branch 'develop' into core_opt_while_op
Xreki 3871afa
Follow comments.
Xreki 9f38bc3
Remove the codes related to prepare the ExecutorPrepareContext for wh…
Xreki File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
cc_library(reset_tensor_array SRCS reset_tensor_array.cc DEPS lod_tensor scope) | ||
cc_library(zero_copy_tensor SRCS zero_copy_tensor.cc DEPS scope lod_tensor enforce) | ||
cc_library(zero_copy_tensor_dummy SRCS zero_copy_tensor_dummy.cc) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -226,7 +226,9 @@ class ReshapeKernel { | |
} | ||
|
||
out->mutable_data(ctx.GetPlace(), in->type()); | ||
framework::TensorCopySync(*in, ctx.GetPlace(), out); | ||
framework::TensorCopy( | ||
*in, ctx.GetPlace(), | ||
ctx.template device_context<platform::DeviceContext>(), out); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @velconia why was this copy sync? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code is a copied from original implementation, but I guess Sync is NO need here. |
||
out->Resize(out_dims); | ||
} | ||
}; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why inference doesn't need to create variables but train need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paddle/paddle/fluid/framework/executor.cc
Lines 413 to 423 in 5d9edb4
When
create_vars
is set totrue
, variables will be created inRunPreparedContext
. Because the step scopes will be used inwhile_grad_op
, so all the step scopes should be saved. So that if there is 100 iterations,CreatedVariables
will be called 100 times.Paddle/paddle/fluid/operators/controlflow/while_op.cc
Lines 84 to 86 in 5d9edb4
For test, the step scopes is deleted at the end of the iteration. In fact, there is no need to new 100 step scopes and call
CreateVariables
100 times. Instead, 1 time is enough. This can reduce the overhead a lot, from17.8619ms
to16.0768ms
.