Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-API quantization core proposal #15834

Closed

Conversation

sfraczek
Copy link
Contributor

Hi,
Please review our proposal of the C-API quantization design. The functionality is not fully complete yet, this is the core part. We are still developing the passes.

@luotao1
Copy link
Contributor

luotao1 commented Feb 21, 2019

There are so many un-related changes in this PR. Could you put them in a sperate PR (maybe we
can merge it) and make this PR more cleaner at first? For example,

  • add sfraczek to authors.md
  • paddle/fluid/framework/ir/xxx_pass.h: const->const override
  • fix typo releated->related
  • paddle/fluid/inference/tests/api/analyzer_xxx_tester.cc: reinterpret_cast<const PaddlePredictor::Config *>(&config)->&config

@luotao1
Copy link
Contributor

luotao1 commented Feb 21, 2019

The functionality is not fully complete yet, this is the core part. We are still developing the passes.

Thanks for your work. It seems good in general for me. I will invite other reviewers after this PR become much cleaner.

@wojtuss
Copy link

wojtuss commented Feb 28, 2019

This PR is updated and turned into final one: #15987

@wojtuss wojtuss closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants