Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff api #16024

Merged
merged 9 commits into from
Mar 3, 2019
Merged

Diff api #16024

merged 9 commits into from
Mar 3, 2019

Conversation

tianshuo78520a
Copy link
Contributor

@tianshuo78520a tianshuo78520a commented Mar 2, 2019

add diff_api illustrate
image

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -26,4 +26,10 @@
print(each_diff)

if error:
print(
'''If you modify/add/delete the API files, including code and comment, please follow these steps in order to pass the CI:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and comment -> codes and comments. 下个PR改吧。

@luotao1 luotao1 merged commit c6f94dd into PaddlePaddle:develop Mar 3, 2019
ceci3 pushed a commit to ceci3/Paddle that referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants