Add enabling quantization #16326
Merged
Add enabling quantization #16326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
luotao1
reviewed
Mar 20, 2019
| @@ -30,6 +30,10 @@ class PaddlePassBuilder { | |||
| explicit PaddlePassBuilder(const std::vector<std::string> &passes) | |||
| : passes_(passes) {} | |||
|
|
|||
| void SetPasses(std::initializer_list<std::string> passes) { | |||
| passes_ = passes; | |||
| } | |||
There was a problem hiding this comment.
why use SetPasses? I don't find it used in #15987 as well.
There was a problem hiding this comment.
The SetPasses is used in quantizer.cc (https://github.com/PaddlePaddle/Paddle/pull/15987/files?file-filters%5B%5D=.cc#diff-2c882d108544e86a1f517bd247ac68ceR352). I have removed its definition from this PR.
wojtuss
pushed a commit
to sfraczek/Paddle
that referenced
this pull request
Mar 21, 2019
* Add enabling quantization test=develop * remove unused (here) function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds option to enable
cpu_quantize_placement_passapplying quantization strategy.test=develop