Docker build #1661
Merged
Docker build #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
requested changes
Mar 21, 2017
paddle/scripts/docker/build.sh
Outdated
| RUN dpkg --force-all -i /usr/local/opt/paddle/deb/*.deb && rm -f /usr/local/opt/paddle/deb/*.deb | ||
| ADD build/*.deb /usr/local/opt/paddle/deb/ | ||
| ADD build/py_paddle*linux*.whl /usr/local/opt/paddle/share/wheels/ | ||
| ADD build/paddle*.whl /usr/local/opt/paddle/share/wheels/ |
There was a problem hiding this comment.
这三个ADD没必要哈，因为deb文件中已经包含了paddle python的库了。下面执行paddle version会自动安装
There was a problem hiding this comment.
Done. Removed last two, I think the first one is necessary.
paddle/scripts/docker/build.sh
Outdated
| ADD build/paddle*.whl /usr/local/opt/paddle/share/wheels/ | ||
|
|
||
| # run paddle version to install python packages first | ||
| RUN dpkg -i /usr/local/opt/paddle/deb/*.deb && rm -f /usr/local/opt/paddle/deb/*.deb && paddle version | ||
|
|
||
| ENV PATH="/usr/local/opt/paddle/bin/:${PATH}" |
There was a problem hiding this comment.
这个ENV也可以去掉了paddle 会安装在/usr/bin下
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1655