python wrap for resize layer

[pengwangucla]

Does not have a test outside in v2, but it works in my code. I don't know whether I need to add it manually.

[qingqing01]

Please refer to this PR to add the unit test.

[wangkuiyi]

Thanks to @pengwangucla for this PR! It would be great if we can have unit tests as well. It seems that the PR mentioned by @qingqing01 is a reference. Please let us know if we can help with the tests.

[pengwangucla]

Sure I will finish it soon. Sorry for missing the comments

…

On Sun, Apr 30, 2017 at 7:35 PM, Yi Wang ***@***.***> wrote: Thanks to @pengwangucla <https://github.com/pengwangucla> for this PR! It would be great if we can have unit tests as well. It seems that the PR mentioned by @qingqing01 <https://github.com/qingqing01> is a reference. Please let us know if we can help with the tests. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1853 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEk8dPP6IBSA0m4CYt2G60s6-md6pzf_ks5r1UTngaJpZM4NE2iH> .

-- Jerry Wang(王鹏） Department of Statistics University of California, Los Angeles Skype: jerrykingpku Phone: +86 15901042108

[pengwangucla]

Please refer to this PR to add the unit test.

@qingqing01 How to run the test.py file, I met this error. Is there a document for this ?

Traceback (most recent call last):
  File "python/paddle/trainer_config_helpers/tests/configs/test_smooth_l1.py", line 3, in <module>
    data = data_layer(name='input', size=300)
  File "/usr/local/lib/python2.7/dist-packages/paddle/trainer_config_helpers/layers.py", line 270, in wrapper
    return method(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/paddle/trainer_config_helpers/layers.py", line 774, in data_layer
    **ExtraLayerAttribute.to_kwargs(layer_attr))
  File "/usr/local/lib/python2.7/dist-packages/paddle/trainer/config_parser.py", line 3236, in Layer
    return layer_func(name, **xargs)
  File "/usr/local/lib/python2.7/dist-packages/paddle/trainer/config_parser.py", line 1699, in __init__
    name, 'data', size, inputs=[], device=device)
  File "/usr/local/lib/python2.7/dist-packages/paddle/trainer/config_parser.py", line 1380, in __init__
    name = MakeLayerNameInSubmodel(name)
  File "/usr/local/lib/python2.7/dist-packages/paddle/trainer/config_parser.py", line 298, in MakeLayerNameInSubmodel
    if (submodel_name is None and not g_add_submodel_suffix and
NameError: global name 'g_add_submodel_suffix' is not defined

[helinwang]

@jacquesqiao can you take a look at this?

[qingqing01]

@pengwangucla run the unit test as follows,

make test ARGS="-R test_layerHelpers -V"

[pengwangucla]

make test ARGS="-R test_layerHelpers -V"

So someone should update the document for writing new layers to add python test.

[pengwangucla]

@qingqing01 @wangkuiyi Add python test and also add '\n' for test_config_parser since someone may not notice to have '\n' at last in the test python file.

[luotao1]

@pengwangucla The travis-ci is broken, please fix it.

[pengwangucla]

what is the pre-commit version online ? I always fail the precommit @luotao1

[pengwangucla]

@luotao1 @qingqing01 @wangkuiyi Fixed the issue

[luotao1]

请问这个文件的修改是必须的么？

[pengwangucla]

Done

[luotao1]

Close due to 9b54ad1