Extend Matmul to support matrix multiplication with multiple heads #18570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the support of multiple head, the multiplication of two big matrixes is split into multiplication of several (head_number) small matrixes. e.g. if Mat A is [3, 24] and Mat B is [24, 4], when multiple A and B with head_number as 4, Mat A will be split as 4 matrix of [3, 6] and Mat B will be 4 matrix of [6, 4]. The result of final matrix will be 4 matrix of [3, 4], i.e. [3, 16]. test=develop
… matmul_with_multiple_head
To support matmul with multiple heads, it requires MKL stride feature of matrix multiplication. test=develop
To support matmul with multiple heads, it requires MKL stride feature of matrix multiplication. test=develop
…/Paddle into matmul_with_multiple_head
…/Paddle into matmul_with_multiple_head
…/Paddle into matmul_with_multiple_head
wojtuss
reviewed
Jul 22, 2019
python/paddle/fluid/tests/unittests/test_matmul_op_with_head.py
Outdated
Show resolved
Hide resolved
python/paddle/fluid/tests/unittests/test_matmul_op_with_head.py
Outdated
Show resolved
Hide resolved
python/paddle/fluid/tests/unittests/test_matmul_op_with_head.py
Outdated
Show resolved
Hide resolved
python/paddle/fluid/tests/unittests/test_matmul_op_with_head.py
Outdated
Show resolved
Hide resolved
… matmul_with_multiple_head
czhu15
force-pushed
the
matmul_with_multiple_head
branch
from
5ce5a01
to
a8a3040
Compare
…/Paddle into matmul_with_multiple_head test=develop
numpy can handle it correctly without user's manual handling. test=develop
wojtuss
reviewed
Jul 23, 2019
luotao1
approved these changes
Jul 24, 2019
| if transpose_X: | ||
| shape_X = [M] | ||
| else: | ||
| shape_X = [K] |
There was a problem hiding this comment.
reduce 4 lines to 1 line.
shape_X = [M] if transpose_X else [K]
You can update in your next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the support of multiple head, the multiplication of two big matrixes is split into multiplication of several (head_number) small matrixes. e.g. if Mat A is [3, 24] and Mat B is [24, 4], when multiple A and B with head_number as 4, Mat A will be split as 4 matrix of [3, 6] and Mat B will be 4 matrix of [6, 4]. The result of final matrix will be 4 matrix of [3, 4], i.e. [3, 16].
Use this new extension, we can avoid head split/merge in Transformer.
first part of #16342