Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate protostr automatically when adding a new test for trainer_config_helpers. #1872

Merged
merged 2 commits into from
Apr 25, 2017
Merged

Generate protostr automatically when adding a new test for trainer_config_helpers. #1872

merged 2 commits into from
Apr 25, 2017

Conversation

qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Apr 24, 2017 •
edited
Loading

It needs to copy the protostr file manually after generating test_xx.protostr.unittest when add a new unit test for trainer_config_helpers now. For example, the test_pad.protostr.unittest will be generated after running:

./python/paddle/trainer_config_helpers/tests/configs/generate_protostr.sh python_path

Then:

cp python/paddle/trainer_config_helpers/tests/configs/protostr/test_pad.protostr.unittest python/paddle/trainer_config_helpers/tests/configs/protostr/test_pad.protostr

This PR is used to generate protostr automatically when running the unit test. For example

make test ARGS="-R test_layerHelpers -V"

luotao1
luotao1 approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 80277b5 into PaddlePaddle:develop Apr 25, 2017
@qingqing01 qingqing01 deleted the config_helper_test branch July 7, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

@reyoung reyoung

@luotao1 luotao1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qingqing01 @luotao1 @reyoung