fix distribute transpiler GRPC error code 4, RPC Deadline #18984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiriosPlus
changed the title
seiriosPlus
changed the title
gongweibao
reviewed
Aug 12, 2019
| @@ -575,7 +575,7 @@ def transpile(self, | |||
| self.grad_name_to_param_name[grad_varname], | |||
| splited_grad_varname | |||
| ], | |||
| "sync_mode": not self.sync_mode, | |||
| "sync_mode": True, | |||
There was a problem hiding this comment.
取消trainer端 rpc client内部的计数，修改为send_op/recv_op内部计数， op不再需要sync_mode
Closed
seiriosPlus
added a commit
to seiriosPlus/Paddle
that referenced
this pull request
Aug 28, 2019
…le#18984) * fix sync mode hang in transpiler * remove sync mode in send/recv * replace PADDLE_ENFORCE with PADDLE_ENFORCE_NE
seiriosPlus
added a commit
that referenced
this pull request
Aug 29, 2019
* fix bug in Class MultiSlotDataGenerator's function _gen_str, test=develop (#18222) * fix some bug when merge sparse embedding parameters, test=develop (#18223) * fix communicator with pyreader (#18350) * delete AllocatorFacade destructor (#18606) * fix distribute transpiler GRPC error code 4, RPC Deadline (#18984) * merge pr #18441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 同步训练 中存在的hang住问题导致GRPC Deadline.
效果验证：
在曾出问题的业务线场景， 累计运行80小时未出GRPC Deadline
TODO:
针对error code 14 的问题，需要对rpc相关设计进行重写后，加入retry修复。