Fix build error in MacOS #1937
Closed
Fix build error in MacOS #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
reyoung
commented
Apr 28, 2017
reyoung
commented
- Because protobuf 3.1.0 uses a deprecated API.
- Partially fix issue The protobuf 3.1.0 cause a warning in MacOS building #1936.
* Because protobuf 3.1.0 uses a deprecated API. * Partially fix issue PaddlePaddle#1936.
wangkuiyi
requested changes
May 1, 2017
| @@ -109,7 +109,8 @@ set(COMMON_FLAGS | |||
| -Wno-unused-function | |||
| -Wno-error=literal-suffix | |||
| -Wno-error=sign-compare | |||
| -Wno-error=unused-local-typedefs) | |||
| -Wno-error=unused-local-typedefs | |||
| -Wno-error=deprecated-declarations) | |||
There was a problem hiding this comment.
no-error-deprecated-declarations 是个我们不希望增加的flag。为什么需要加上呢？
There was a problem hiding this comment.
因为我们使用了Protobuf 3.1.0，但是Protobuf 3.1.0自己有一个地方使用了 deprecated API。Protobuf的issue在这里
如果要根治这个问题，我们需要将Prootbuf升级到3.2.0。但是，目前临时fix这个问题，我们先将这个warning在develop branch中，不将其看成error。
|
Close due to Mac build is successful now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.