Fuse fc+reshape+transpose+scale for ernie opt. #19526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop Signed-off-by: zhaoyuchen <zhaoyuchen01@baidu.com>
test=develop Signed-off-by: zhaoyuchen <zhaoyuchen01@baidu.com>
zhaoyuchen2018
force-pushed
the
ernie_opt
branch
from
53a679f
to
f0c7746
Compare
test=develop Signed-off-by: zhaoyuchen <zhaoyuchen01@baidu.com>
3 tasks
test=develop Signed-off-by: zhaoyuchen <zhaoyuchen01@baidu.com>
zhaoyuchen2018
force-pushed
the
ernie_opt
branch
from
6e68c33
to
b438c2e
Compare
Xreki
reviewed
Oct 25, 2019
| } | ||
|
|
||
| PDNode* FCReshapeTransposePattern::operator()( | ||
| paddle::framework::ir::PDNode* x) { |
There was a problem hiding this comment.
这个函数从240行到395行，一共155行代码，太长了。fuse的3个分支结构差不多的吧，可以用循环来写。
|
|
||
| fc_rts_pattern(x); | ||
| // Create New OpDesc | ||
| auto fuse_creater = [&]( |
There was a problem hiding this comment.
这个函数从41行到170行，一是代码行数太多，二是函数的参数太多了，会导致代码的可读性和可扩展性很差。
| namespace ir { | ||
| namespace patterns { | ||
|
|
||
| struct FCReshapeTransposePattern : public PatternBase { |
There was a problem hiding this comment.
这个pattern应该只在这个pass里面用到，可以放到.cc文件里面。
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ |
There was a problem hiding this comment.
注意下copyright的格式，另外copyright里面应该都是2019年。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test=develop