optimize the GPU inplementation of stack_op #19610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sic_ops pass. test=develop
test=develop
test=develop
test=develop
Xreki
force-pushed
the
pass_opt_stack
branch
from
1d10ffd
to
266e0d8
Compare
test=develop
test=develop
test=develop
|
@NHZlX , |
|
@Xreki, |
|
@jeng1220 Yes, I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack_op's function is the same as concat, except the output's dims. We can call concat functor to optimize it. The current code is implemented by thrust which may generate the calling of
cudaMalloc,cudaFreeandWait. See the timelien of ernie (PaddlePaddle/benchmark#165 (comment)):