Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paddle::framework::vectorize() templatization [PART3] #19643

Merged
merged 5 commits into from
Sep 9, 2019
Merged

paddle::framework::vectorize() templatization [PART3] #19643

merged 5 commits into from
Sep 9, 2019

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Sep 5, 2019

Suggested in #19510 changes to paddle::framework::vectorize() function.

This PR remove std::vector<int> vectorize2int(const DDim& ddim) and update all framework::vectorize2int to framework::vectorize<int>. This PR is the next of #19611 and #19627

@luotao1
Copy link
Contributor Author

luotao1 commented Sep 6, 2019

image
The update on unsqueeze_op.cc and warpctc_cudnn_op.cu.cc fails on unit-test coverage. And if fix the unit-test in this PR, it exceeds the file limits.

@luotao1 luotao1 requested a review from sneaxiy September 8, 2019 10:11
Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sneaxiy sneaxiy merged commit f05d2c5 into PaddlePaddle:develop Sep 9, 2019
@luotao1 luotao1 deleted the vector2int branch September 9, 2019 02:22
@grygielski grygielski mentioned this pull request Oct 10, 2019
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
…9643)

* paddle::framework::vectorize() templatization

test=develop

* update pybind/imperative.cc

test=develop

* revert update on unsqueeze_op.cc and warpctc_cudnn_op.cu.cc

test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants