paddle::framework::vectorize() templatization [PART4] #19730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused accuracy-diff warpctc-cudnn implementation test=develop
luotao1
changed the title
wanghaoshuang
approved these changes
Sep 11, 2019
heavengate
approved these changes
Sep 11, 2019
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
remove unused accuracy-diff warpctc-cudnn implementation test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested in #19510 changes to
paddle::framework::vectorize()function.std::vector<int> vectorize2int(const DDim& ddim)inddim.hframework::vectorize2inttoframework::vectorize<int>, we find thatwarpctc_cudnn_op.cu.ccuses the oldframework::vectorize2intinterface. Discussed with @wanghaoshuang, since warpctc-cudnn implementation always has accuracy-diff in both python2.7 and python3.5, and it will not be maintained later, this PR remove it.