Implement a pass detect fusion group of elementwise op #19884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
test=develop
test=develop
| input_names.push_back(n->Name()); | ||
| external_nodes.insert(n); | ||
| } | ||
| op_desc.SetInput("Xs", input_names); |
There was a problem hiding this comment.
名字需要与fusion_group op的Maker定义一致，我在实现fusion_group op的PR里面改吧。
| namespace fusion_group { | ||
|
|
||
| struct SubGraph { | ||
| int type{-1}; |
There was a problem hiding this comment.
SubGraph 有哪几种type 改成enum 方式可以更清晰直观点
There was a problem hiding this comment.
后面肯定要引入不同的type的，但目前我们只支持elementwise类型，所以先用int，后面再改吧。
wangchaochaohu
approved these changes
Oct 29, 2019
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
…19884) * Add fusion_group_pass and elementwise pattern. * Rewrite the detector of elementwise group. test=develop * Add a comment in codegen. * Add more unittest cases. test=develop * Move code_generator related code to fusion_group directory. * Correct the including path. * Add the definition of SubGraph and finish the insert of fusion_group op in pass. * Insert graph_vis_pass in tester to visualize the graph for debug.
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
…19884) * Add fusion_group_pass and elementwise pattern. * Rewrite the detector of elementwise group. test=develop * Add a comment in codegen. * Add more unittest cases. test=develop * Move code_generator related code to fusion_group directory. * Correct the including path. * Add the definition of SubGraph and finish the insert of fusion_group op in pass. * Insert graph_vis_pass in tester to visualize the graph for debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two cases are given in
fusion_group_pass_tester.Case 1
Case 2