Add padding to FC op #19996
Closed
Add padding to FC op #19996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
luotao1
reviewed
Oct 28, 2019
paddle/fluid/operators/math/fc.cc
Outdated
| for (int i = 0; i < M; i++) { | ||
| memcpy(X1_data + i * (K + 4), X + i * K, K * sizeof(X[0])); | ||
| } | ||
| if (N % 128 == 0 && K % 128 == 0) { |
There was a problem hiding this comment.
将memory copy放到if条件里，性能没有变化。
原因是ERNIE中GEMM尺寸都能被128整除。
GaoWei8
force-pushed
the
padding
branch
2 times, most recently
from
1fc4066
to
a08f4f4
Compare
test=develop
test=develop
GaoWei8
force-pushed
the
padding
branch
3 times, most recently
from
0101c59
to
bf96829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add padding in paddle and the size of padding is same with BERT.