Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix expand bug #20340

Merged
merged 5 commits into from
Oct 10, 2019
Merged

fix expand bug #20340

merged 5 commits into from
Oct 10, 2019

Conversation

wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Oct 9, 2019

expand前向和后向传播类型不一致的bug修复 同时添加类型检查

需求描述:

1、expand的前向和后向注册的dtype kernel不一致

2、期望加入规范,并且增加排查,如果特殊的可以单独说明

3、报错信息用户:该问题报错信息只能内部研发才能看得出原因,不利用用户自己排查问题

需求来源:

· 链接:#19878

· 问题:optimizer.minimize(avg_cost)无法反向传播

· 解答:maxdisp, mask_sum这些设置stop_gradient=True试下

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu merged commit 1288ac2 into PaddlePaddle:develop Oct 10, 2019
guoshengCS pushed a commit to guoshengCS/Paddle that referenced this pull request Oct 12, 2019
* fix expand bug test=develop

* fix style test=develop

* fix style test=develop

* fix style test=develop

* fix style test=develop
guoshengCS added a commit that referenced this pull request Oct 13, 2019
* Add seq2seq api related code (#19820)

* fix expand bug  (#20340)

* fix expand bug test=develop

* fix style test=develop

* fix style test=develop

* fix style test=develop

* fix style test=develop

* Fix the assign data check (#20564)

* Fix the assign data check. test=develop

* Fix test_assign_op.py. test=develop

* Update API.spec
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
* fix expand bug test=develop

* fix style test=develop

* fix style test=develop

* fix style test=develop

* fix style test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants