-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dst memory allocation in elementwise_add #21059
Merged
luotao1
merged 1 commit into
PaddlePaddle:develop
from
wojtuss:wojtuss/fix-alloc-dst-memory-eltwise_add
Nov 8, 2019
Merged
Fix dst memory allocation in elementwise_add #21059
luotao1
merged 1 commit into
PaddlePaddle:develop
from
wojtuss:wojtuss/fix-alloc-dst-memory-eltwise_add
Nov 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
jczaja
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@luotao1 ^^ |
@ceci3 Please take a review here! |
ceci3
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please cherry-pick into release/1.6 |
wojtuss
pushed a commit
to wojtuss/Paddle
that referenced
this pull request
Nov 12, 2019
Disable cudnn_conv in Parallel Executor unit tests. (PaddlePaddle#21083) TODO: fix cudnn_conv and re-enable it test=develop test=release/1.6 Fix dst memory allocation in elementwise_add (PaddlePaddle#21059) test=release/1.6
bingyanghuang
added a commit
to bingyanghuang/Paddle
that referenced
this pull request
Nov 13, 2019
luotao1
pushed a commit
that referenced
this pull request
Nov 13, 2019
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch temporarily fixes destination primitive memory allocation for 'elementwise_add' op. A final fix will be done by @jczaja and/or @grygielski with their gradual refactoring of the MKL-DNN-based operators.
(A fix for #20998)
test=develop