Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dst memory allocation in elementwise_add #21059

Conversation

wojtuss
Copy link

@wojtuss wojtuss commented Nov 6, 2019

This patch temporarily fixes destination primitive memory allocation for 'elementwise_add' op. A final fix will be done by @jczaja and/or @grygielski with their gradual refactoring of the MKL-DNN-based operators.

(A fix for #20998)

test=develop

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingyanghuang
Copy link
Contributor

@luotao1 ^^

@luotao1 luotao1 requested a review from ceci3 November 8, 2019 03:38
@luotao1
Copy link
Contributor

luotao1 commented Nov 8, 2019

@ceci3 Please take a review here!

Copy link
Contributor

@ceci3 ceci3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit af3ff42 into PaddlePaddle:develop Nov 8, 2019
@luotao1
Copy link
Contributor

luotao1 commented Nov 12, 2019

Please cherry-pick into release/1.6

wojtuss pushed a commit to wojtuss/Paddle that referenced this pull request Nov 12, 2019
Disable cudnn_conv in Parallel Executor unit tests. (PaddlePaddle#21083)

TODO: fix cudnn_conv and re-enable it

test=develop
test=release/1.6

Fix dst memory allocation in elementwise_add (PaddlePaddle#21059)

test=release/1.6
bingyanghuang added a commit to bingyanghuang/Paddle that referenced this pull request Nov 13, 2019
luotao1 pushed a commit that referenced this pull request Nov 13, 2019
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants